Please fix OpenMP support detection on macOS #6409
Milestone
Comments
barracuda156
referenced
this issue
Aug 27, 2024
* improve OpenMP detection on macOS * detect LLVM OpenMP builds * remove some comments * define _OPENMP when using LLVM libomp * fix nesting for 'echo no' * let openmp warning stand out a bit more * Always redirect to config.log, not /dev/null * NEWS * Restore deletion of all test-omp* artefacts * try and reduce diff by restoring comment * reduce diff: delete in same order * annotate 'fi' for readability --------- Co-authored-by: Michael Chirico <[email protected]>
kevinushey
added a commit
that referenced
this issue
Aug 27, 2024
|
Thank you! |
MichaelChirico
added a commit
that referenced
this issue
Aug 30, 2024
* also check plain '-fopenmp' for gcc (closes #6409) * update NEWS * cite in NEWS --------- Co-authored-by: Michael Chirico <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The code in configure for OpenMP on macOS is incorrect: it assumes Clang with
libopm, so the check fails with GCC, where OpenMP is supported in fact. Instead, compiler should be checked first: if GCC is detected, OpenMP should be set to supported, and only Clang needs a test, because it may or may not havelibomp.The text was updated successfully, but these errors were encountered: