Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set digits= and warn= to their normal defaults before testing #6052

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented Apr 6, 2024

Closes #5285
Closes #4936

Copy link

codecov bot commented Apr 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.51%. Comparing base (9e93067) to head (c35abcd).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6052   +/-   ##
=======================================
  Coverage   97.51%   97.51%           
=======================================
  Files          80       80           
  Lines       14918    14920    +2     
=======================================
+ Hits        14547    14549    +2     
  Misses        371      371           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelChirico
Copy link
Member Author

This is pretty low-risk and test-only, merging.

@MichaelChirico MichaelChirico merged commit b058f62 into master Apr 6, 2024
5 checks passed
@MichaelChirico MichaelChirico deleted the test-fix-warnings branch April 6, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail when run with some non-default options Tests fail when digits option is set.
1 participant