Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal set of changes to permit master to be 1.17.99 #6829

Merged

Conversation

eddelbuettel
Copy link
Contributor

Congratulations on getting 1.17.0 onto CRAN.

As with previous releases, master lags as is still at 1.16.99 in DESCRIPTION and src/init.c (plus some .po files I left alone). Feel free to add to the PR as needed.

@eddelbuettel eddelbuettel force-pushed the feature/inc_dev_version branch from 0391620 to 5bab86d Compare February 22, 2025 13:06
Copy link

codecov bot commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.64%. Comparing base (4b3a081) to head (98c68d9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6829   +/-   ##
=======================================
  Coverage   98.64%   98.64%           
=======================================
  Files          79       79           
  Lines       14642    14642           
=======================================
  Hits        14444    14444           
  Misses        198      198           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TysonStanley
Copy link
Member

Thanks @eddelbuettel, didn't get this in last night after it was accepted, thanks for getting it started. @MichaelChirico this should be all the files that are needed to bump to 1.17.99

@MichaelChirico
Copy link
Member

atime & lintr failures are OK. Latter is due to some improved logic just landed upstream, will fix that separately.

thanks!

@MichaelChirico MichaelChirico merged commit f78044e into Rdatatable:master Feb 22, 2025
7 of 9 checks passed
@MichaelChirico
Copy link
Member

@TysonStanley maybe the procedure should be to push an "as-submitted" release branch, then anyone who sees it hit CRAN can merge async, WDYT?

of course if it's rejected, the PR can be deleted

@TysonStanley
Copy link
Member

I'm open to that since the process is a bit prolonged and often ends in the evening or middle of the night.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants