Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Twitter - Hide recommended users): add new timeline entryId prefix #4456

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

trogper
Copy link

@trogper trogper commented Feb 13, 2025

twitter has started (a long ago) to use who-to-subscribe- prefix instead of who-to-follow-

this adds the new prefix, so it is properly blocked again

!fixes

@trogper
Copy link
Author

trogper commented Feb 14, 2025

this actually won't work on newer versions of twitter apk, since TwiFucker used to hook onto org.json and they replaced org.json library with LoganSquare.

@LisoUseInAIKyrios
Copy link
Contributor

Are any of the old strings still used (whoToFollow-, who-to-follow-, etc)?

I guess it doesn't cause any harm leaving them since they're very unique and false positives seem unlikely, but if it's 100% certain the old strings are not used then they can be removed.

@trogper
Copy link
Author

trogper commented Feb 17, 2025

I am not sure. I tried adding logging to the hook, but as I later found out, that won't work because of the library replacement.

@LisoUseInAIKyrios
Copy link
Contributor

this actually won't work on newer versions of twitter apk, since TwiFucker used to hook onto org.json and they replaced org.json library with LoganSquare.

That would mean a lot of other filtering is also broken.

What is the last version that this does work? A recommended version can be added until someone figures out a fix for the latest Twitter release.

@trogper
Copy link
Author

trogper commented Feb 18, 2025

According to issue 521, it stopped working before August of 2023. But that may also be caused by change of the prefix.

The folks at crimera/piko have working twitter patches, but they are based on older versions of revanced patch API, so it's incompatible with current revanced cli/app for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(Twitter / X - Hide recommended users): Who to Follow is not hiding
2 participants