Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Simplify @return sentences in Flowable JavaDocs #6847

Merged
merged 5 commits into from
Jan 16, 2020

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Jan 15, 2020

Simplify the wording of @return in JavaDocs.

Resolves #6834

@codecov
Copy link

codecov bot commented Jan 15, 2020

Codecov Report

Merging #6847 into 3.x will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6847      +/-   ##
============================================
+ Coverage     98.25%   98.26%   +0.01%     
+ Complexity     6380     6377       -3     
============================================
  Files           715      715              
  Lines         46522    46522              
  Branches       6387     6387              
============================================
+ Hits          45711    45716       +5     
- Misses          287      291       +4     
+ Partials        524      515       -9
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/reactivex/rxjava3/core/Flowable.java 100% <ø> (ø) 576 <0> (ø) ⬇️
src/main/java/io/reactivex/rxjava3/core/Maybe.java 100% <ø> (ø) 178 <0> (ø) ⬇️
...in/java/io/reactivex/rxjava3/core/Completable.java 100% <ø> (ø) 120 <0> (ø) ⬇️
...rc/main/java/io/reactivex/rxjava3/core/Single.java 100% <ø> (ø) 151 <0> (ø) ⬇️
...o/reactivex/rxjava3/parallel/ParallelFlowable.java 100% <ø> (ø) 57 <0> (ø) ⬇️
...ain/java/io/reactivex/rxjava3/core/Observable.java 100% <ø> (ø) 551 <0> (ø) ⬇️
...java3/internal/observers/FutureSingleObserver.java 94.33% <0%> (-3.78%) 24% <0%> (-1%)
...l/operators/observable/ObservableFlatMapMaybe.java 89.43% <0%> (-2.12%) 2% <0%> (ø)
.../internal/disposables/ListCompositeDisposable.java 98% <0%> (-2%) 34% <0%> (-1%)
...ava3/internal/operators/parallel/ParallelJoin.java 92.04% <0%> (-1.14%) 3% <0%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fec1c7...bab7cf6. Read the comment docs.

@akarnokd akarnokd merged commit 021d07b into ReactiveX:3.x Jan 16, 2020
@akarnokd akarnokd deleted the ReturnsSimpleDoc3x branch January 16, 2020 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.x: Replace the verbose @return entires with simpler ones
1 participant