Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated loop parameter #575

Merged

Conversation

carlwgeorge
Copy link
Contributor

asyncio.sleep's loop parameter has been deprecated since Python 3.8, and is removed in 3.10. The tests fail on 3.10 unless this is removed.

asyncio.sleep's loop parameter has been deprecated since Python 3.8, and
is removed in 3.10.  The tests fail on 3.10 unless this is removed.

https://docs.python.org/3.10/library/asyncio-task.html#sleeping
Copy link
Collaborator

@MainRo MainRo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.506% when pulling eece568 on carlwgeorge:sleep-deprecated-loop-parameter into 5a0e902 on ReactiveX:master.

@MainRo MainRo merged commit 246eabf into ReactiveX:master Jul 3, 2021
@carlwgeorge carlwgeorge deleted the sleep-deprecated-loop-parameter branch July 4, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants