-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wxscheduler issues #602
Fix wxscheduler issues #602
Conversation
Hi, thanks for the PR. We are discussing if we should deprecate them so things are not decided yet. Activity is always a good sign of not deprecating. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing. PS: You might want to also make a PR against the reactivex
branch that will be the next version of RxPY (code name ReactiveX)
@christiansandberg Could I ask you to please update your PR against the latest v4 code, and I will make sure the scheduler will be part of the release and not be deprecated. |
Oh okay, I thought you would merge both to master eventually. I'll make a new PR. |
PS: See instructions here for setting up the development environment: https://github.com/ReactiveX/RxPY#development |
* Could not schedule actions from other threads * Slow `schedule` method
270b8d3
to
c07e746
Compare
Ok, I've rebased on top of master now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for fixing!
I just saw that you are planning on deprecating these schedulers but since I already made the fixes I'm making a PR anyway.
The Timer class used for scheduling actions has a few drawbacks:
observe_on
useless.