Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect comment in dtrsv.f #931

Closed
DrTimothyAldenDavis opened this issue Nov 10, 2023 · 2 comments · Fixed by #933
Closed

incorrect comment in dtrsv.f #931

DrTimothyAldenDavis opened this issue Nov 10, 2023 · 2 comments · Fixed by #933

Comments

@DrTimothyAldenDavis
Copy link

In the reference BLAS, dtrsv.f, the function is incorrectly listed as a BLAS level1 method:

lapack/BLAS/SRC/dtrsv.f

Line 144 in 8ecaaf9

* -- Reference BLAS level1 routine --

See also line 139.

The other [dcz]strv.f functions have "level2" in their comments.

I haven't checked for incorrect references in the rest of the BLAS, but it would be a good idea to check that.
langou added a commit that referenced this issue Nov 10, 2023
@langou
fix #931
44e942d 
fix typo for the blas level of BLAS/SRC/DTRSV
@langou langou mentioned this issue Nov 10, 2023
Merged
weslleyspereira added a commit that referenced this issue Nov 10, 2023
@weslleyspereira
Merge pull request #933 from Reference-LAPACK/issue931_timdavis__inco…
43a55bc 
…rrect_blas_level_in_dtrsv

fix #931
@langou
Copy link
Contributor

langou commented Nov 10, 2023

Thanks @DrTimothyAldenDavis. This should be fixed.

@DrTimothyAldenDavis
Copy link
Author

Woohoo ... I found my first BLAS "bug" ;-)

OK, not really a bug; just a minor documentation glitch. But I'm sure fixes even as trivial as this in the Fortran reference BLAS are rare.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #931 Reference-LAPACK/lapack
2 participants
@langou @DrTimothyAldenDavis