Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formatter module #24

Merged
merged 6 commits into from
May 14, 2024
Merged

Add formatter module #24

merged 6 commits into from
May 14, 2024

Conversation

k3ii
Copy link
Contributor

@k3ii k3ii commented May 2, 2024

No description provided.

@k3ii k3ii self-assigned this May 2, 2024
@k3ii k3ii marked this pull request as ready for review May 2, 2024 10:58
@k3ii k3ii requested a review from a team as a code owner May 2, 2024 10:58
@puzzledvacuum
Copy link
Contributor

Hi @k3ii, have you been able to test the library? If not, how would you go about testing this change?

@k3ii
Copy link
Contributor Author

k3ii commented May 2, 2024

@puzzledvacuum , there's been only formatting changes.
I will be testing it when ritdu-core-eu1-ebs-snapshots-cleaner will be deployed. I've added the label "Do not Merge" for now.

@k3ii k3ii removed the Do Not Merge label May 9, 2024
@k3ii
Copy link
Contributor Author

k3ii commented May 9, 2024

@puzzledvacuum , I tested the formatter and it works great 🥳 .
Can you approve it, please?

@puzzledvacuum
Copy link
Contributor

@k3ii Can you add tests that will be run when the action is run?

Copy link
Contributor

@puzzledvacuum puzzledvacuum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💎

@puzzledvacuum
Copy link
Contributor

Nice one @k3ii 💪

Once this is merged I can do a deploy then it is live.

@puzzledvacuum
Copy link
Contributor

FYI: A deploy is triggered by pushing a tag

@k3ii k3ii merged commit 547bd72 into main May 14, 2024
2 checks passed
@puzzledvacuum puzzledvacuum deleted the Formatter branch May 14, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants