Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated EmberError and assign #59

Conversation

wozny1989
Copy link
Contributor

@wozny1989 wozny1989 commented Jul 9, 2024

@wozny1989 wozny1989 changed the title Remove deprecated EmberError Remove deprecated EmberError and assign Jul 9, 2024
@RobbieTheWagner RobbieTheWagner added the enhancement New feature or request label Aug 20, 2024
@RobbieTheWagner RobbieTheWagner merged commit 194ebb5 into RobbieTheWagner:main Aug 20, 2024
2 checks passed
@dwickern
Copy link

@RobbieTheWagner could you make a release with this fix? It's a blocker for ember v5

@RobbieTheWagner
Copy link
Owner

@dwickern yes, apologies for the delay! I need to update this addon in general and setup release-plan so we can easily do releases in the future.

@dwickern
Copy link

Thank you! ember-ajax is archived and ember-fetch removed all of its functionality in version 8. This addon seems like the easiest path forward.

@RobbieTheWagner
Copy link
Owner

2.0.0 has been released, please let me know how it works for you!

@dwickern
Copy link

Works great!

I see now there's an RFC to deprecate ember-fetch. If that happens, maybe this addon could drop the ember-fetch dependency and wire up the test waiters directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants