Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable build an instance of the Consul client with a custom HTTP connector #44

Closed
LeonHartley opened this issue Apr 15, 2024 · 0 comments

Comments

@LeonHartley
Copy link
Contributor

LeonHartley commented Apr 15, 2024

While attempting to use turmoil with this Consul client, we noticed that you can't override the hyper HTTP connector that gets used when building the hyper client.

It'd be nice if we could override the whole process of building the HTTP client, and not just the builder, so we can use this library with turmoil, e.g:

rs-consul/src/lib.rs

Lines 255 to 256 in e18ce70

let https = https_connector();
let https_client = config.hyper_builder.build::<_, hyper::Body>(https);

Turmoil example, using hyper:
https://github.com/tokio-rs/turmoil/blob/main/examples/axum/src/main.rs#L57

kushudai added a commit that referenced this issue Jul 20, 2024
Add `ConsulBuilder` allowing a consul client to be built using a custom HTTP connector, fixes #44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant