fix(trace): align span status per OpenTelemetry specs #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update HTTP client span annotation to mark both client (4xx) and server (5xx) errors while preserving unset status for 1xx/2xx/3xx responses. Aligns with OpenTelemetry HTTP semantic conventions for client instrumentation. Ref: https://opentelemetry.io/docs/specs/semconv/http/http-spans/#status Signed-off-by: Ville Vesilehto <[email protected]>
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
I have read the CLA Document and I hereby sign the CLA |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are we solving?
Previously, any non-200 HTTP response would set the span status to error in
hyper_wrapper.rs. According to OpenTelemetry specs, this should only happen on client errors (4xx) and server errors (5xx).How are we solving the problem?
Aligning the implementation to match OpenTelemetry spec: https://opentelemetry.io/docs/specs/semconv/http/http-spans/#status
Checks
Please check these off before promoting the pull request to non-draft status.