-
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS: convert pdf files to rst and add them to docs #319
Conversation
If you guys want to check a preview of the html render from the .rst file, I suggest using the following code:
The theme and colors, however, will be different than the expected to be once merged, but you can verify how the equations will be displayed, for example. |
Alright! this makes for a much easier timer reviewing and editing these docs files. Here are some issues:
Image doesn't have a background (I fixed it in the last commit)
If you generate the
|
Thanks for reviewing it, @MateusStano !! I'll comment everything in the same order, here we go:
|
Ok, everything done, ready for a re-review! The Thks again. To proper test the docs, one can use the following commands:
|
This is happening due to some configurations at the current theme version. Updating the pydata-sphinx-theme to a newer version allowed me to wrap these equations within the text limit. Well, ateast I don't see how to solce that with the current pydata-sphinx-theme version. ... Adding @giovaniceotto here , can we consider upgrading the pydata-sphinx-theme package version from our docs page? Currently it is fixed to pydata-sphinx-theme==0.6.3 version, but there's already a 0.12 version available, we are outdated! Probably some problems can be generated on that transition, I can help to fix any issues that appers in the docs with new version. |
Heym it seems that pydata/pydata-sphinx-theme#1196 solved the issue that @MateusStano caught above. Therefore I updated the pydata-sphinx-theme version in the requirements for docs. Eberything should be running again. @MateusStano please confirm that you can build the docs locally by running the following code and then we can move to merge. The conflict can be ignored, I already checked and nothing will be lost when deleting the .pdf files.
Take a look at the preview! |
All good now! I think we might need to update the EOM documentation because of what has been developed in Liquids, but that is for another time. Feel free to merge whenever Also I solved =the conflicts by just accepting the deletion of the .pdf file |
Only documentation files being modified, this PR goes directly into master branch, |
Pull request type
Please check the type of change your PR introduces:
Pull request checklist
Please check if your PR fulfills the following requirements, depending on the type of PR:
ReadMe, Docs and GitHub maintenance:
What is the current behavior?
There are two .pdf files with documentation purposes in our repo. They are indeed very well written and provide good information to the users and contributors. However, git cannot read changes on these files, therefore it is hard to keep them on track.
What is the new behavior?
Now we can track the changes on the old `technical' documentation files. Also, I'm adding the 'equations of motion' file, which sometimes even our main developers kinda forget that it exists. By promoting it to our docs page, it will get more visibility, and we get one more step on RocketPy's docs.
Does this introduce a breaking change?
Other information