-
-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add improved normal2height node #755
base: master
Are you sure you want to change the base?
Conversation
I'm not really sure if it makes sense to keep the existing, simple node |
I should note that the strength and base height parameters don't work exactly like in the existing node. It's just a simple |
One issue I've found is that high sample counts (4k or more) often result in crashes with textures above 512 resolution. However this is more of an issue with MM than this node in particular. If Iterate Buffers exposed the iteration number, I could use them to spread the calculation across multiple invocations and the crash could likely be avoided. |
I have a version in the works that uses an iterate buffer. That makes it more stable. And I've improved the quality further. |
From my side this PR is done |
Add my normal2height node to the base library.
The default node works fine for very simple geometric shapes, but for real normal maps it produces very strong streaking artifacts.
This improved node is based on Materialize's height from normal generator.
Probably the sampling sequence and performance can still be improved. But it's not bad. Also I haven't done any spell checking.
I'll keep this as a draft until initial feedback.