Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotation to make-rust-unicode-data.py #2529

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

tamaroning
Copy link
Contributor

@tamaroning tamaroning commented Aug 6, 2023

Addresses this comment by @CohenArthur

I think this is a very good first implementation of the script :) For future maintainability, I think it would be helpful to add types to the script so we can run it with mypy. But this is already very good, don't change it in this PR

#2425 (comment)

Python code was typechecked with mypy 1.4

gccrs: Type annotation for make-unicode-data.py
gcc/rust/ChangeLog:

	* util/make-rust-unicode.py: Add type annotation

gcc/rust/ChangeLog:

	* util/make-rust-unicode.py: Add type annotation

Signed-off-by: Raiki Tamura <[email protected]>
Copy link
Member

@philberty philberty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philberty philberty added this pull request to the merge queue Aug 12, 2023
@philberty philberty added this to the GCC 14 Stage 3 milestone Aug 12, 2023
Merged via the queue into Rust-GCC:master with commit 87c5cc1 Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants