Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement HashToScalar for P-384 #600

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Implement HashToScalar for P-384 #600

merged 1 commit into from
Feb 1, 2023

Conversation

daxpedda
Copy link
Contributor

@daxpedda daxpedda commented Jun 11, 2022 •
edited
Loading

tarcieri added a commit to RustCrypto/crypto-bigint that referenced this pull request Jun 12, 2022
@tarcieri
Add U576 type alias
62bb24d 
Useful for RustCrypto/elliptic-curves#600 as well as `p521`.
@tarcieri tarcieri mentioned this pull request Jun 12, 2022
Merged
tarcieri added a commit to RustCrypto/crypto-bigint that referenced this pull request Jun 12, 2022
@tarcieri
Add U576 type alias (#94)
0307d22 
Useful for RustCrypto/elliptic-curves#600 as well as `p521`.
@daxpedda daxpedda mentioned this pull request Jun 13, 2022
Merged
@daxpedda daxpedda force-pushed the p384-hash-to-curve branch from 1511404 to 94482ff Compare June 13, 2022 01:41
@daxpedda
Copy link
Contributor Author

daxpedda commented Jun 13, 2022 •
edited
Loading

So this has to build on RustCrypto/traits#1024 now. Considering this will be a breaking change, what's the solution here?
I could just copy-paste the OSSWU code here, like we did in k256. Or should we just delay this PR? Or release an elliptic-curve 0.13-pre?

I'm in no particular hurry btw, delaying is fine with me.

@daxpedda daxpedda requested a review from tarcieri June 13, 2022 02:03
@daxpedda daxpedda changed the title Implement HashToScalar Implement HashToScalar for P-384 Jun 13, 2022
@tarcieri
Copy link
Member

I think it'd probably make sense to just delay the PR until the next round of breaking changes to elliptic-curve, and in the meantime perhaps we could work out some better solutions for RustCrypto/traits#1024 regarding the relationships between FieldElements and their inner UInts.

@daxpedda daxpedda mentioned this pull request Nov 19, 2022
Merged
@daxpedda daxpedda force-pushed the p384-hash-to-curve branch 2 times, most recently from 417c61c to 3e213f8 Compare December 7, 2022 13:49
@daxpedda daxpedda marked this pull request as ready for review December 7, 2022 13:50
@daxpedda
Copy link
Contributor Author

daxpedda commented Dec 7, 2022

Rebased.
I guess this now depends on elliptic-curve 0.13.0-pre.0 being released.

@tarcieri
Copy link
Member

tarcieri commented Dec 7, 2022 •
edited
Loading

@daxpedda I'd like to get v0.12 releases of all of these crates out that move to the primeorder crate's generic implementation and bumps to signature v2.0 before upgrading elliptic-curve to v0.13.0-pre.0, since the former two are already significant changes.

That's all pretty much blocked on another release of ed25519-dalek to keep everything in sync.

@daxpedda
Copy link
Contributor Author

daxpedda commented Dec 7, 2022

Alright, good to know!
I'm in no rush :).

@daxpedda daxpedda mentioned this pull request Dec 7, 2022
Merged
@daxpedda

This comment was marked as outdated.

Sign in to view
@daxpedda daxpedda mentioned this pull request Dec 9, 2022
Merged
@daxpedda
Copy link
Contributor Author

daxpedda commented Feb 1, 2023

@tarcieri this is ready now.

@tarcieri tarcieri merged commit 302a3f3 into RustCrypto:master Feb 1, 2023
@daxpedda daxpedda mentioned this pull request Feb 1, 2023
Merged
@daxpedda daxpedda mentioned this pull request Nov 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarcieri tarcieri tarcieri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daxpedda @tarcieri