Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include CONFIGURE.md in generated documentation #164

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

squioc
Copy link
Collaborator

@squioc squioc commented Feb 13, 2025

Include CONFIGURE.md and docs/assets/ into the generated documentation of automation modules.

The purpose is to improve the documentation of automation modules with a section explaining how to generate the credentials for the module.
This information will be put in the CONFIGURE.md in the automation module. Assets like images will be put in docs/assets in the automation module.

@squioc squioc added the enhancement New feature or request label Feb 13, 2025
@squioc squioc requested review from Darkheir and a team February 13, 2025 13:33
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 90.34%. Comparing base (f18bea4) to head (68d99a2).

Files with missing lines Patch % Lines
...ekoia_automation/scripts/documentation/generate.py 25.00% 12 Missing ⚠️

❌ Your patch check has failed because the patch coverage (25.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
- Coverage   90.76%   90.34%   -0.42%     
==========================================
  Files          35       35              
  Lines        2500     2516      +16     
==========================================
+ Hits         2269     2273       +4     
- Misses        231      243      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 13, 2025

Test Results

222 tests  ±0   221 ✅ ±0   1m 45s ⏱️ +2s
  1 suites ±0     1 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 68d99a2. ± Comparison against base commit f18bea4.

♻️ This comment has been updated with latest results.

@squioc squioc force-pushed the feat/AutomationDocGeneration branch from 624e570 to c7322bc Compare February 13, 2025 13:40
with (module_path / "CONFIGURE.md").open("r") as fd:
content = fd.read()

# Copy the assets for the documentation and update the path
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the assets copy should be independant from the configure.md in case we want to also include images in the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants