Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add susChkSrv HA/DR provider and make providers configurable #153

Merged
merged 2 commits into from
Nov 8, 2023
Merged

add susChkSrv HA/DR provider and make providers configurable #153

merged 2 commits into from
Nov 8, 2023

Conversation

yeoldegrove
Copy link
Collaborator

@yeoldegrove yeoldegrove commented Nov 6, 2023 •
edited
Loading

  • add susChkSrv HA/DR provider
  • make providers configurable

This will be a part of fixing SUSE/ha-sap-terraform-deployments#910

@yeoldegrove yeoldegrove self-assigned this Nov 6, 2023
@yeoldegrove yeoldegrove requested a review from arbulu89 November 7, 2023 08:24
@yeoldegrove yeoldegrove changed the title add susChkSrv HA/DR provider add susChkSrv HA/DR provider and make providers configurable Nov 7, 2023
@yeoldegrove yeoldegrove mentioned this pull request Nov 7, 2023
Merged
angelabriel
angelabriel reviewed Nov 7, 2023
View reviewed changes
Copy link
Contributor

@angelabriel angelabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
But I would prefer to switch the defaults for susTkOver and susChkSrv from enabled to disabled because both hooks are NOT mandatory. So the customer should actively enable the hooks so that he knows what is going on on his HANA cluster.

@stefanotorresi
Copy link
Contributor

I agree that the additional hooks should be disabled by default.

angelabriel
angelabriel approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@angelabriel angelabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for switching the default 😄

arbulu89
arbulu89 approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good!
Only one comment so you can improve the yaml code

@yeoldegrove
add susChkSrv HA/DR provider
ea1816b 
make providers configurable
@yeoldegrove yeoldegrove merged commit 8d456d8 into main Nov 8, 2023
yeoldegrove added a commit that referenced this pull request Nov 8, 2023
@yeoldegrove
Merge pull request #153 from SUSE/feat/susChkSrv
4930943 
add susChkSrv HA/DR provider and make providers configurable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelabriel angelabriel angelabriel approved these changes

@arbulu89 arbulu89 arbulu89 approved these changes

Assignees

@yeoldegrove yeoldegrove

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yeoldegrove @stefanotorresi @angelabriel @arbulu89