Better URL comparison for metrics #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v2-master #206 +/- ##
=============================================
- Coverage 53.18% 53.18% -0.01%
=============================================
Files 918 918
Lines 25290 25290
Branches 4336 4336
=============================================
- Hits 13451 13450 -1
- Misses 11839 11840 +1 |
richard-cox
approved these changes
Sep 9, 2019
* Doc refinement to cf pushed stratos Remind persistent database is still suppored to enable user favorites * Fix typo
…-local-user Allow local user to be configured via Helm value
…er-metrics-url-compare Better URL comparison for matching Metrics endpoints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When comparing URLs to match a metrics endpoint with other endpoints that it might provide metrics for, we now use a better comparison that doesn't just compare strings - which fixes issues when the mismatch is only in the port number due to default port.