Helm: Allow users to view and use repositories from Helm Hub #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
richard-cox
commented
Sep 1, 2020
•
richard-cox
commented
- fixes Helm: Allow users to view and use repositories from Helm Hub #445
- To review
- Update register helm hub ui component
- need to add endpoint type specific actions to endpoints list view (helm sync)
- use for helm sync
- favourite cards are NOT by subtype, so parent type must have label info
- Fix display of disconected text & box in endpoint favourite card - Don't go out to fetch helm schema if there's none defined - Fixes following merge
|
I've updated following review comments. The Charts list repo filter --> side bar change is still pending |
richard-cox
commented
Sep 11, 2020
| @@ -51,14 +51,20 @@ export interface HelmInstallValues { | |||
| releaseName: string; | |||
| releaseNamespace: string; | |||
| values: string; | |||
| chart: string; | |||
| chart: { | |||
There was a problem hiding this comment.
find common type (name/repo/version)
richard-cox
commented
Sep 11, 2020
| constructor( | ||
| store: Store<any>, | ||
| public helper: HelmReleaseHelperService, | ||
| private route: ActivatedRoute, |
richard-cox
commented
Sep 11, 2020
| @@ -256,7 +256,7 @@ export class CreateReleaseComponent implements OnInit, OnDestroy { | |||
| ...this.details.value, | |||
| ...this.overrides.value, | |||
| chart: { | |||
| name: this.route.snapshot.params.name, | |||
| chartName: this.route.snapshot.params.chartName, | |||
richard-cox
commented
Sep 11, 2020
| @@ -62,7 +63,8 @@ export class UpgradeReleaseComponent { | |||
| const name = chart.upgrade.name; | |||
| const repoName = chart.upgrade.repo.name; | |||
| const version = chart.release.chart.metadata.version; | |||
| this.listConfig = new ReleaseUpgradeVersionsListConfig(store, repoName, name, version); | |||
| this.listConfig = new ReleaseUpgradeVersionsListConfig(store, repoName, name, version, chart.monocularEndpointId); | |||
There was a problem hiding this comment.
const version = chart.release.chart.metadata.version; pattern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.