Fix application of maxed lists following page refresh
#559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue - When there are too many resources to show in a list we enter `max` state - When in max'd state we force the user to select filters to restrict the number of results (changing filters results in new https requests containing those filters) - We persist the state of the list to local storage. This includes filters but does not include the `max` flag - When the user re-vists the list after page refresh instead of fetching all resources we only fetch those applicable to the filter (which will be a small subset of all resources). As the `max` flag isn't there we assume we've fetched all resources. Any changes to the filter are then applied locally to the subset of resources... which won't contain any from the new filter Fix - Persist the list's `max` state such that when the list loads again all filter changes correctly result in http requests - This needed a fix in the way we watch the filters for changes (we block this watch until all filters report as ready) - Fix downside - Lists cannot ever leave the `max` state. All changes to filters will result in http requests. User would need to clear their local cache to reset the list (we have a button for this in the user's profile page) Tested - Different types of org/space filter setups - orgs with no spaces - orgs with some spaces under maxed, some over - Different types of lists - Tested with UI_LIST_ALLOW_LOAD_MAXED true (allow user to overrule maxed state and fetch everything)
nwmac
approved these changes
Nov 23, 2022
richard-cox
force-pushed
the
fix-refresh-maxed-list
branch
from
182656c to
69f6a91
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #559 +/- ##
=======================================
Coverage 28.65% 28.65%
=======================================
Files 60 60
Lines 5126 5126
=======================================
Hits 1469 1469
Misses 3470 3470
Partials 187 187 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #560
Issue
maxstatemaxflagmaxflag isn't persisted we assume we've fetched all resources. Any changes to the filter are then applied locally to the subset of resources... which may not contain any applicable to the new filterFix
maxstate such that when the list loads again all filter changes correctly result in http requestsmaxstate. All changes to filters will result in http requests. User would need to clear their local cache to reset the list (we have a button for this in the user's profile page)Tested