test: e2e tests for proposals new dynamic material table #1766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tProject/frontend into add-dynamic-material-table
…tProject/frontend into add-dynamic-material-table
…' of https://github.com/SciCatProject/frontend into SWAP-4456-dataset-metadata-improvements
…hub.com/SciCatProject/frontend into SWAP-4456-dataset-metadata-improvements
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @martin-trajanovski - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding comments or documentation for the new utility functions like 'getFormattedTime' to clarify their purpose and usage.
- Ensure consistent use of single or double quotes in the Cypress tests for better readability and maintainability.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
src/app/shared/modules/dynamic-material-table/utilizes/default-table-config.ts
Show resolved
Hide resolved
src/app/shared/modules/dynamic-material-table/utilizes/default-table-config.ts
Outdated
Show resolved
Hide resolved
…ps://github.com/SciCatProject/frontend into SWAP-4539-e2e-tests-for-the-new-proposals-table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds e2e tests for the new proposal table and also improve the syncing of the default and saved table settings.
Motivation
e2e tests for the new proposal table were missing and sync of the saved and default settings wasn't working properly.
Fixes:
Changes:
Please provide a list of the changes implemented by this PR
Tests included
Documentation
official documentation info
If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included
Backend version