-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dotnet] [bidi] Add network SetCacheBehavior command #15133
[dotnet] [bidi] Add network SetCacheBehavior command #15133
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
dotnet/src/webdriver/BiDi/Modules/BrowsingContext/BrowsingContextNetworkModule.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice!
User description
Description
Expanding BiDi coverage in .NET
Motivation and Context
Fixes #14532
Types of changes
Checklist
PR Type
Enhancement, Tests
Description
Added
SetCacheBehavior
command to the Network module in .NET BiDi.Implemented
SetCacheBehaviorCommand
and related parameters and options.Updated
BrowsingContextNetworkModule
andNetworkModule
to support cache behavior configuration.Added unit tests to validate
SetCacheBehavior
functionality.Changes walkthrough 📝
Command.cs
Register `SetCacheBehaviorCommand` in command types
dotnet/src/webdriver/BiDi/Communication/Command.cs
SetCacheBehaviorCommand
as a derived type for networkcommands.
BrowsingContextNetworkModule.cs
Add `SetCacheBehaviorAsync` to BrowsingContextNetworkModule
dotnet/src/webdriver/BiDi/Modules/BrowsingContext/BrowsingContextNetworkModule.cs
SetCacheBehaviorAsync
method to configure cache behavior.SetCacheBehaviorOptions
for browsing context.NetworkModule.cs
Implement `SetCacheBehaviorAsync` in NetworkModule
dotnet/src/webdriver/BiDi/Modules/Network/NetworkModule.cs
SetCacheBehaviorAsync
method inNetworkModule
.SetCacheBehaviorCommandParameters
and options.SetCacheBehaviorCommand.cs
Add `SetCacheBehaviorCommand` and related classes
dotnet/src/webdriver/BiDi/Modules/Network/SetCacheBehaviorCommand.cs
SetCacheBehaviorCommand
class and parameters.SetCacheBehaviorOptions
andCacheBehavior
enum.NetworkTest.cs
Add unit tests for `SetCacheBehavior`
dotnet/test/common/BiDi/Network/NetworkTest.cs
SetCacheBehavior
functionality.