Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bazel] Bump rules_python to 1.1.0 #15139

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Conversation

shs96c
Copy link
Member

@shs96c shs96c commented Jan 23, 2025

PR Type

enhancement, configuration changes


Description

  • Updated rules_python dependency to version 1.1.0.

  • Added precompile = "disabled" to py_library and pytest_test.

  • Improved Bazel configuration for Python test suites.


Changes walkthrough 📝

Relevant files
Enhancement
suite.bzl
Add `precompile` option to Python test suite                         

py/private/suite.bzl

  • Added precompile = "disabled" to py_library and pytest_test.
  • Enhanced Python test suite configuration.
  • +2/-0     
    Configuration changes
    MODULE.bazel
    Bump `rules_python` dependency version                                     

    MODULE.bazel

    • Updated rules_python dependency from 0.33.0 to 1.1.0.
    +1/-1     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Configuration Impact

    Disabling precompilation for Python tests may impact test execution performance. Verify this change is intentional and aligns with project requirements.

    precompile = "disabled",

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @shs96c shs96c merged commit a080ec5 into SeleniumHQ:trunk Jan 23, 2025
    9 checks passed
    @shs96c shs96c deleted the bump-rules-python branch January 23, 2025 15:15
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant