Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Remove deprecated non-w3c compliant NetworkConnection interface #15270

Merged
merged 4 commits into from
Feb 11, 2025

Conversation

pujagani
Copy link
Contributor

@pujagani pujagani commented Feb 11, 2025

User description

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Enhancement, Tests, Bug fix


Description

  • Removed deprecated NetworkConnection interface and related implementations.

  • Updated ChromiumDriver to eliminate NetworkConnection references.

  • Deleted associated tests and configurations for NetworkConnection.

  • Cleaned up unused commands and dependencies in various files.


Changes walkthrough 📝

Relevant files
Enhancement
5 files
ChromiumDriver.java
Removed `NetworkConnection` references and methods.           
+0/-18   
NetworkConnection.java
Deleted deprecated `NetworkConnection` interface.               
+0/-136 
DriverCommand.java
Removed `NetworkConnection` related commands.                       
+0/-3     
AbstractHttpCommandCodec.java
Removed `NetworkConnection` command definitions.                 
+0/-10   
RemoteNetworkConnection.java
Deleted deprecated `RemoteNetworkConnection` implementation.
+0/-54   
Tests
1 files
NetworkConnectionTest.java
Removed tests for `NetworkConnection`.                                     
+0/-60   
Bug fix
1 files
spotbugs-excludes.xml
Removed `NetworkConnection` related SpotBugs exclusion.   
+1/-6     
Configuration changes
2 files
BUILD.bazel
Removed `mobile` package from Bazel build configuration. 
+0/-1     
BUILD.bazel
Deleted Bazel build configuration for `NetworkConnection` tests.
+0/-18   

Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @pujagani pujagani marked this pull request as ready for review February 11, 2025 09:27
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 PR contains tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Breaking Change

    Removal of NetworkConnection interface and related functionality could break existing code that depends on these deprecated network connection features. Consider adding migration guide or deprecation notice.

    public class ChromiumDriver extends RemoteWebDriver
        implements HasAuthentication,
            HasBiDi,
            HasCasting,
            HasCdp,
            HasDevTools,
            HasLaunchApp,
            HasLogEvents,
            HasNetworkConditions,
            HasPermissions,
            LocationContext,
            WebStorage {

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @pujagani pujagani merged commit 7ed1679 into SeleniumHQ:trunk Feb 11, 2025
    27 of 34 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant