fix(Dropdown): clear searchQuery on item selection by mouse click #3317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove check to have consistent behavior with `selectItemOnEnter` Relates to Semantic-Org#3306
Codecov Report
@@ Coverage Diff @@
## master #3317 +/- ##
==========================================
- Coverage 99.89% 99.89% -0.01%
==========================================
Files 170 170
Lines 2802 2801 -1
==========================================
- Hits 2799 2798 -1
Misses 3 3
Continue to review full report at Codecov.
|
layershifter
reviewed
Dec 4, 2018
| @@ -729,8 +729,7 @@ export default class Dropdown extends Component { | |||
| this.setValue(newValue) | |||
| this.setSelectedIndex(value) | |||
|
|
|||
| const optionSize = _.size(this.getMenuOptions()) | |||
| if (!multiple || isAdditionItem || optionSize === 1) this.clearSearchQuery() | |||
| this.clearSearchQuery() | |||
There was a problem hiding this comment.
This change is absolutely valid, we did this in #2162 and even had an comment about this #2162 (comment).
See our decision #2162 (comment). I checked examples manually, LGTM.
|
@kohakukun thanks for the investigation 👍 |
layershifter
changed the title
|
Congrats on merging your first pull request! 🎉🎉🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
selectItemOnEnterFixes #3306.