Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Tab): panes type definition #3496

Merged
merged 1 commit into from
Mar 13, 2019
Merged

Conversation

mbakiev
Copy link
Contributor

@mbakiev mbakiev commented Mar 12, 2019

Type definition for Tab prop pane is incorrect.

In reference to #3495

Type definition for Tab prop pane is incorrect
@welcome
Copy link

welcome bot commented Mar 12, 2019

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io
Copy link

Codecov Report

Merging #3496 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3496      +/-   ##
==========================================
- Coverage   99.82%   99.75%   -0.08%     
==========================================
  Files         172      172              
  Lines        2804     2804              
==========================================
- Hits         2799     2797       -2     
- Misses          5        7       +2
Impacted Files Coverage Δ
src/modules/Search/Search.js 98.39% <0%> (-1.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0c71d9...e08b7ab. Read the comment docs.

@mbakiev
Copy link
Contributor Author

mbakiev commented Mar 12, 2019

Not clear on why this change is causing coverage problems in search.

@levithomason
Copy link
Member

Thanks. The project coverage is odd but the patch coverage is correct and changes look good.

@levithomason levithomason changed the title Fix Tab type definition fix(Tab): panes type definition Mar 13, 2019
@levithomason levithomason merged commit 5ce220f into Semantic-Org:master Mar 13, 2019
@welcome
Copy link

welcome bot commented Mar 13, 2019

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@levithomason
Copy link
Member

Released in [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants