LibGfx/JPEGXL: VarDCT-related progress #25755
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We still render the final image using only the last decoded frame, so that's not a huge progress but at least allows the decoder to progress a little bit further.
In other words, don't apply color transformations if it's not requested.
The enum will be used before the class declaration.
And properly define default values.
github-actions
bot
added
the
👀 pr-needs-review
nico
reviewed
Mar 6, 2025
| FixedArray<IntPoint> positions; | ||
| }; | ||
|
|
||
| ErrorOr<Patch> read_patch(LittleEndianInputBitStream& stream, EntropyDecoder& decoder, u32 num_extra_channels) |
nico
reviewed
Mar 6, 2025
| return patch; | ||
| } | ||
|
|
||
| ErrorOr<FixedArray<Patch>> read_patches(LittleEndianInputBitStream& stream, u32 num_extra_channels) |
This will need to be used in the rendering pipeline too, but we are not there yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that I didn't upstream my last work on modular images, so instead of making progress in this area, I decided to work on VarDCT. More specifically, I worked on this conformance test.
The image is composed of two frames, one kReferenceOnly (modular) and one kNormalFrame (VarDCT). With these commits, we can decode everything until the VarDCT-specific data in the LfGlobal of the second frame.