Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap seekbar position with player buttons in background player screen #24

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

ShareASmile
Copy link
Owner

@ShareASmile ShareASmile commented Jun 16, 2024

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Fixes the following issue(s)

Full Screen Minimize Gesture Conflicts with Background Player Track Progress / Seek Bar
Fixes: Following Upstream NewPipe Issues for Newpipe Legacy Revo Preunified
TeamNewPipe/NewPipe#6788
TeamNewPipe/NewPipe#2931

Relies on the following changes

Fetches Changes from TeamNewPipe/NewPipe#6824 into Newpipe Legacy Preunified Thanks to @phigjm

  1. Reorder the Control Elements of the background player (putting the Title down)
  2. Add new icons in background player by avently in upstream v0.20.0
  3. made image view from playQueue visible by avently in commit
    TeamNewPipe/NewPipe@dd726fa#diff-EFCAA05775EEBAE5D5E7D3DD8FB04196 from Player overlays now centered TeamNewPipe/NewPipe#4360

Testing apk

Newpipe_Legacy_play_queue_control_rearrangment_debug.zip

Or download artifact fron actions
https://github.com/ShareASmile/NewPipe-Legacy-Revo/actions/runs/9535958262/artifacts/1606053550

Agreement

reorder the Control Elements of the background player (putting the Title down) TeamNewPipe/NewPipe#6824
Fixes: TeamNewPipe/NewPipe#6788
TeamNewPipe/NewPipe#2931

new icons in background player by avently commit

made image view from playQueue visible by avently in commit
TeamNewPipe/NewPipe@dd726fa#diff-EFCAA05775EEBAE5D5E7D3DD8FB04196
from TeamNewPipe/NewPipe#4360

Co-Authored-By: Stanislav Dmitrenko <[email protected]>
Co-Authored-By: wb9688 <[email protected]>
Co-Authored-By: phigjm <[email protected]>
@ShareASmile ShareASmile merged commit 9a16def into revo Jun 16, 2024
1 check passed
@ShareASmile ShareASmile deleted the play_queue_control_rearrangement branch June 16, 2024 13:21
Repository owner locked and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant