-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: User imports #15
base: main
Are you sure you want to change the base?
WIP: User imports #15
Conversation
… but refactored to follow the structure of the newly refactored proc macro crate.
… but refactored to follow the structure of the newly refactored proc macro crate.
a52cd57
to
7f9332f
Compare
7f9332f
to
12e9835
Compare
12e9835
to
177f715
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have reviewed commit 7deaf49, all good. Will proceed to next commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at all the source code changes everything looks good. I think if we could add a quick example to the examples which uses this new import functionality in order to confirm it runs as expected that would be best, probably just copy existing example code but move some of the shader code to a different module that we then import.
As mentioned above it would be ideal to have a new example in the examples directory which utilizes this new functionality. Feel free to copy an existing example, since the theoretically correct outputs for those have already been determined. And then just run |
Work in progress, but functional.
make a library module, make functions, static consts, and helper types public then use the module inside of your wgsl module.
Limitations:
In Progress:
::