Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fallback for missing subscribers #3731

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Add fallback for missing subscribers #3731

merged 1 commit into from
Feb 26, 2025

Conversation

haeky
Copy link
Contributor

@haeky haeky commented Feb 25, 2025

PR Summary:

In some cases, the eventName doesn't have any subscribers. To make sure that the method always return a Promise, let's catch these cases.

Checklist

@lhoffbeck lhoffbeck self-requested a review February 25, 2025 23:30
@haeky haeky merged commit e1f06f4 into main Feb 26, 2025
8 checks passed
@haeky haeky deleted the pubsub-fallback branch February 26, 2025 14:12
NathanScheele pushed a commit to Misha-Puff/dawn that referenced this pull request Mar 3, 2025
@nathan-scheele
Add fallback for missing subscribers (Shopify#3731)
b5eeeac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhoffbeck lhoffbeck lhoffbeck approved these changes

@ludoboludo ludoboludo ludoboludo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haeky @lhoffbeck @ludoboludo