Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No executor error #48

Merged
merged 3 commits into from
Feb 23, 2017
Merged

No executor error #48

merged 3 commits into from
Feb 23, 2017

Conversation

xuorig
Copy link
Contributor

@xuorig xuorig commented Feb 23, 2017

Forgetting to use GraphQL::Batch.batch, or to use the Setup instrumenter when using graphql-ruby results in a NoMethodError: undefined method loaders' for nil:NilClass`.

Would be pretty useful to display a good error message there, wdyt ?

@xuorig xuorig merged commit e807d2b into Shopify:master Feb 23, 2017
@xuorig xuorig deleted the no-executor-error branch February 23, 2017 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants