Add .gitignore for new projects

[adrhumphreys]

Added git ignore, to ignore the node_modules and dist folder for new projects

What are you trying to accomplish with this PR?

This adds a gitignore file by default so that node_modules and dist don't get commited to sc by accident

#126

[chrisberthe]

Can you add a trailing slash to these to signify they're directories?

[adrhumphreys]

Woops, added them in there 👍

[chrisberthe]

Thanks @adrhumphreys for the PR - just a small comment. @NathanPJF I've assigned you for some additional 👀.

[adrhumphreys]

Awesome, @chrisberthe I've add the trailing slashes

[t-kelly]

Hey @adrhumphreys 👋 - have you had a chance to test this out?

The .gitignore file you've added won't do anything because the dist/ and node_modules/ don't live inside the src/ folder, they live inside the root folder. We have a .gitignore file for the root directory that ignores both node_modules/ and dist/.

Is the existing setup not working for you? Care to elaborate as to how you ended up with dist/ and node_modules/ in the src/ folder?

[t-kelly]

Sorry, I saw in your issue that the problem is that .gitignore is not being copied over when we create a new theme. The solution should still be to copy the .gitignore to the root folder, not the src folder.

[chrisberthe]

As @t-kelly mentioned, this doesn't solve the issue of ignoring the node_modules and dist folder - the .gitignore should be placed inside of the root theme directory, not src.

Closing this PR for now, but we'll definitely revisit this soon - maybe we could initialize this with a flag upon running slate theme and/or slate migrate... but don't necessarily want to clutter up options for each of those commands either. We'll 🤔.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.