Skip to content
This repository was archived by the owner on Jul 19, 2021. It is now read-only.

add a sample gitignore #179

Merged
merged 4 commits into from
Jun 16, 2017
Merged

add a sample gitignore #179

merged 4 commits into from
Jun 16, 2017

Conversation

NathanPJF
Copy link
Contributor

What are you trying to accomplish with this PR?

Partially address #126

Creating a sample gitignore tailored for a new Slate project. The .gitignore-sample file is now part of slate-src.zip which is used by the theme.js command in slate-cli.

Checklist

For contributors:

For maintainers:

  • I have 🎩'd these changes.
  • I have bumped the package.json version in a separate PR, if applicable.

@NathanPJF NathanPJF requested a review from chrisberthe June 16, 2017 18:01
Copy link
Contributor

@chrisberthe chrisberthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor tweaks - otherwise 👍

docs/index.md Outdated

## Working with `git`

A new Slate project comes with a `.gitignore-sample` file. This file is meant to be a starting point for your own `.gitignore` file if you will be using `git` for version control. The sample files contains a list of files and folders to be ignored when committing to a git repository. Ignored files are both Slate project specific files as well as commonly ignored files on any project.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double space before "Ignored files".

docs/index.md Outdated

A new Slate project comes with a `.gitignore-sample` file. This file is meant to be a starting point for your own `.gitignore` file if you will be using `git` for version control. The sample files contains a list of files and folders to be ignored when committing to a git repository. Ignored files are both Slate project specific files as well as commonly ignored files on any project.

For more information on this `.gitignore` files, see GitHub's documentation: https://help.github.com/articles/ignoring-files/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"gitignore file"

@NathanPJF NathanPJF merged commit 4372f84 into master Jun 16, 2017
@NathanPJF NathanPJF deleted the sample-gitignore branch June 16, 2017 18:59
@lock
Copy link

lock bot commented Oct 26, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants