This repository was archived by the owner on Jul 19, 2021. It is now read-only.
Support js and js.liquid theme js #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 🚢 We'll need to port this over to sl8-toolz |
|
@cshold if you want to copy this over there, that would be great. |
t-kelly
pushed a commit
that referenced
this pull request
Jul 31, 2017
* throw error on build when config.yml is missing * fixes zip task * updated node stuffs
t-kelly
pushed a commit
that referenced
this pull request
Jul 31, 2017
* throw error on build when config.yml is missing * fixes zip task * updated node stuffs
t-kelly
pushed a commit
that referenced
this pull request
Jul 31, 2017
* throw error on build when config.yml is missing * fixes zip task * updated node stuffs
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our tooling should support the root
theme.jsif it's a liquid file, as seen in many of our older themes. This PR does a few things:.jsand.js.liquidfilesconfig.ymlin favour ofconfig-sample.yml— gitignore doesn't ignore already checked in filesconfig.src.vendorJspathscripts/vendor/*.jswould actually uploadtheme.jsand notvendor.jsFixes https://github.com/Shopify/themes-dev-workflow/issues/586
@macdonaldr93 @stevebosworth
cc @richgilbank