This repository was archived by the owner on Jul 19, 2021. It is now read-only.
Toggle linting #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PS: I think it was this part of
We had an extra compile on |
| @@ -16,7 +17,7 @@ var messages = require('./includes/messages.js'); | |||
| * @memberof slate-cli.tasks.build | |||
| * @static | |||
| */ | |||
| gulp.task('build:css', ['lint:css'], function() { | |||
| gulp.task('build:css', [].concat(lintTask), function() { | |||
There was a problem hiding this comment.
Any reason not to just put lintTask?
There was a problem hiding this comment.
My thought was to make it more obvious that additional tasks should be added in the first array. But maybe that's overkill. Thoughts?
|
Sweeeeeet 👍 |
|
R+ 🚀 re: watchify, might be worth opening an issue on the GH project. |
|
👍 |
|
#toolate |
t-kelly
pushed a commit
that referenced
this pull request
Jul 31, 2017
* Clone a repo to your project folder * Changes * changes * Changes * Change * refactor some code * install dependencies * remove random files * git init and replace slate pkg * add git/yeoman tpl files/env questions * finish todos and start commenting code * remove extra logs * update comment on private function * add last private function comment * absolute dep * commit stuff * get generator files from slate repo * pull templates from cache * fix indent
t-kelly
pushed a commit
that referenced
this pull request
Jul 31, 2017
t-kelly
pushed a commit
that referenced
this pull request
Jul 31, 2017
* Clone a repo to your project folder * Changes * changes * Changes * Change * refactor some code * install dependencies * remove random files * git init and replace slate pkg * add git/yeoman tpl files/env questions * finish todos and start commenting code * remove extra logs * update comment on private function * add last private function comment * absolute dep * commit stuff * get generator files from slate repo * pull templates from cache * fix indent
t-kelly
pushed a commit
that referenced
this pull request
Jul 31, 2017
t-kelly
pushed a commit
that referenced
this pull request
Jul 31, 2017
* Clone a repo to your project folder * Changes * changes * Changes * Change * refactor some code * install dependencies * remove random files * git init and replace slate pkg * add git/yeoman tpl files/env questions * finish todos and start commenting code * remove extra logs * update comment on private function * add last private function comment * absolute dep * commit stuff * get generator files from slate repo * pull templates from cache * fix indent
t-kelly
pushed a commit
that referenced
this pull request
Jul 31, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Shopify/themes-fed
Added a boolean to toogle in config.js to enable/disable linting on build/watch. You can always run the test task to lint.
I ended combining an update to browserify in here. Watch task wasn't working very well - sometimes it wouldn't upload, other times it would upload twice - so I flipped it over to chokidar and set it to re-bundle on file change. We get to remove watchify which was the 5th slowest dependency. @m-ux and @t-kelly if you guys could review this in depth that would be great.