add production env #84
Conversation
|
This works. The only alternative I could think of would be to leave |
|
I like it 👍 Will running |
|
Only concern is that |
|
Could we add a step in the |
|
@t-kelly we wanted to reduce time to on-boarding and complexity of on-boarding. Asking someone for a theme id might confuse theme as they might not have a store yet, or be ready to upload the theme. Obviously up to you guys how you want to handle this but that was the original thought process. There used to be 4-5 questions to generate a new theme and we had a templating language to inject those variables and generate the appropriate theme... but it didn't seem necessary if someone just wanted to take a peak at a boilerplate theme. |
|
I totally agree with the philosophy - but is it okay that we throw them into a dev environment without a way to immediately preview the current state of their project? I feel like that could be something that required when setting up your new theme? |
|
Hmmmm... yeah I'm not sure what's better. Getting a theme id isn't easy so it might turn people away but then slate might seem broken without the theme id. Maybe a/b test? haha I'm not sure what the better situation is. |
|
Merging this as a band-aid fix for the issues reported in Shopify/slate-tools#39. I recognize this requires an extra step when testing, but it's worth it to avoid having devs accidentally wipe their live site. You can always write the env flag if you don't want to go looking for the theme id: Also, now the |
* simplify to requiring in theme commands * dynamically pull in theme commands and move global commands out * remove minimist * move theme creation to command and other functions to utils * group variables * add comments to functions * move out output slate theme check * remove extra variable * touch up output * redo shrinkwrap * improve error output * add clean up after theme download * add prompt when dirName isn't provided * reword prompt message * move babel-polyfill from devDep to dep * update dirName regex * remove &
* simplify to requiring in theme commands * dynamically pull in theme commands and move global commands out * remove minimist * move theme creation to command and other functions to utils * group variables * add comments to functions * move out output slate theme check * remove extra variable * touch up output * redo shrinkwrap * improve error output * add clean up after theme download * add prompt when dirName isn't provided * reword prompt message * move babel-polyfill from devDep to dep * update dirName regex * remove &
* simplify to requiring in theme commands * dynamically pull in theme commands and move global commands out * remove minimist * move theme creation to command and other functions to utils * group variables * add comments to functions * move out output slate theme check * remove extra variable * touch up output * redo shrinkwrap * improve error output * add clean up after theme download * add prompt when dirName isn't provided * reword prompt message * move babel-polyfill from devDep to dep * update dirName regex * remove &
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fix for #83
Partial fix for Shopify/slate-tools#39
@macdonaldr93 @cshold @t-kelly Any concerns about this? Alternatively, I just remove "live" as the initial value.