[Vue] RouteLinkedRichText #1037
Conversation
| @@ -111,4 +112,85 @@ describe('<RichText />', () => { | |||
| expect(rendered.attributes()).toMatchObject(attrs); | |||
| expect(rendered.element.innerHTML).toBe(props.field.value); | |||
| }); | |||
|
|
|||
| it('should initialize links', () => { | |||
There was a problem hiding this comment.
This test doesn't check that link is initialized, you just check markup
in order to check that link is initialized, you should try to click, you need to understand that this.routeHandler is assigned to the event listener, you have such test at the bottom
| expect(rendered.element.innerHTML).toContain('<a href="/t10">2</a>'); | ||
| }); | ||
|
|
||
| it('should not initialize links when does not have value', () => { |
There was a problem hiding this comment.
This test not related to the links, it's just a test which check that nothing is rendered
you just need to rename it properly
| const hasChildNodes = rendered.element.hasChildNodes(); | ||
| expect(hasChildNodes).toBe(false); | ||
| }); | ||
| it('should not initialize links if no links in markup', () => { |
There was a problem hiding this comment.
This test is not related to the links, we have the same case covered in another test, can be removed
and if you check that you don't have <a href='' /> - it doesn't check that links are not initialized
| expect(rendered.element.innerHTML).toContain('<h1>Hello!</h1>'); | ||
| expect(rendered.element.innerHTML).not.toContain('<a href='); | ||
| }); | ||
| it('should navigate if anchor element clicked', async () => { |
There was a problem hiding this comment.
This test can be renamed to -> Should initialize links
There was a problem hiding this comment.
And inside this test you can check both cases, when you have nested element and link, so you can click on nested, after that on parent and check it here
| expect(mockRouter.push).toHaveBeenCalledTimes(1); | ||
| expect(mockRouter.push).toHaveBeenCalledWith('/styleguide'); | ||
| }); | ||
| it('should navigate if nested element clicked', async () => { |
…r. Cleaned the return of render func.
Description / Motivation
Testing Details
Types of changes