Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[React] Resolve duplicate react instances issue #1091

Merged
merged 2 commits into from
Jul 7, 2022
Merged

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Jul 5, 2022

Description / Motivation

  • React throws invalid hook call error in case multiple react instances are used in the sample
  • By default yarn doesn't solve duplicate react dependencies issue
  • react-app-rewire provides way to customize webpack config for create-react-app template
  • Provided alias for webpack config, to have a single react instance

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team July 5, 2022 13:36
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Not ideal, but this seems like our best option for monorepo support (matches the approach we take with the nextjs template).

@ambrauer ambrauer merged commit e23ece7 into dev Jul 7, 2022
@ambrauer ambrauer deleted the feature/539873 branch July 7, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants