Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] Fix compilers proxy options in template #1107

Merged
merged 1 commit into from
Jul 29, 2022
Merged

[Vue] Fix compilers proxy options in template #1107

merged 1 commit into from
Jul 29, 2022

Conversation

unrevised6419
Copy link
Contributor

@unrevised6419 unrevised6419 commented Jul 16, 2022

Description / Motivation

After some analysis of the project, it seems the compilers option is not used anymore.
It was renamed to requireArg?: string | null;

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

In general, I see that the Vue template is very outdated.
I'm working on a new template that uses Vite and supports TypeScript
https://github.com/jagaad/create-sitecore-jss-vue

After some analysis of the project, it seems the `compilers` option is not used anymore.  
It was renamed to `requireArg?: string | null;`
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for the fix!

As for the template in general, we do have it in our backlog to support TypeScript. We are also considering options for SSG support in the future (Nuxt or Vite), but this is not in the roadmap as of yet.

@ambrauer ambrauer merged commit f05e868 into Sitecore:dev Jul 29, 2022
@unrevised6419 unrevised6419 deleted the patch-1 branch August 1, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants