[Next.js][Multi-site] Create plugin approach for extract-path #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambrauer
approved these changes
Dec 19, 2022
|
|
||
| export class PathExtractor { | ||
| /** | ||
| * Allow plugins to extract normalized path |
There was a problem hiding this comment.
I'd keep this more generic (there's more work done in here than just the plugins)
Suggested change
| * Allow plugins to extract normalized path | |
| * Extract normalized Sitecore item path |
Comment on lines
5
to
8
| /** | ||
| * Extract normalized Sitecore item path from query | ||
| * @param {string} path | ||
| */ |
There was a problem hiding this comment.
Can probably remove the jsdoc comment here (we don't do this for other plugin's execs, "query" no longer makes sense anyway)
Suggested change
| /** | |
| * Extract normalized Sitecore item path from query | |
| * @param {string} path | |
| */ |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Added plugin approach for
extract-pathfunctionalityTesting Details
Types of changes