Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sitecore-jss-proxy] Upgrade 3rd party dependencies #1362

Merged
merged 2 commits into from
Mar 6, 2023
Merged

[sitecore-jss-proxy] Upgrade 3rd party dependencies #1362

merged 2 commits into from
Mar 6, 2023

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented Mar 2, 2023 •
edited
Loading

  • Upgrade http-proxy-middleware

  • Remove @types/http-proxy-middleware as http-proxy-middleware provides its own type definitions.

  • This PR follows the Contribution Guide

Description / Motivation

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania addy-pathania requested a review from a team March 2, 2023 21:23
@illiakovalenko
Copy link
Contributor

@sc-addypathania Build is failed, double-check unit tests

@addy-pathania
Copy link
Contributor Author

@sc-addypathania Build is failed, double-check unit tests

@illiakovalenko fixed

illiakovalenko
illiakovalenko approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! 👍

@illiakovalenko illiakovalenko merged commit 3fd6a9a into dev Mar 6, 2023
@illiakovalenko illiakovalenko deleted the feature/573761-proxy-middleware-upgrade branch March 6, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addy-pathania @illiakovalenko