[RAV][nextjs] Ensure component works when default personalization variant is hidden #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illiakovalenko
approved these changes
Mar 22, 2023
| @@ -211,6 +211,8 @@ export class PlaceholderCommon<T extends PlaceholderProps> extends React.Compone | |||
|
|
|||
| if (componentRendering.componentName === HIDDEN_RENDERING_NAME) { | |||
| component = hiddenRenderingComponent ?? HiddenRendering; | |||
| } else if (!componentRendering.componentName) { | |||
| component = () => <></>; | |||
There was a problem hiding this comment.
It's possible to render null value, did you try to set null?
There was a problem hiding this comment.
I think either one should work (null is set anyway, so another piece of code would need to be changed), but this approach is a better fit for the code flow we have now (there's a null check below that actually triggers the issue).
There was a problem hiding this comment.
Also it helps differentiate between an "empty" component (all good - means it's hidden) and "null" component (throws error, causes error frame to render).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Personalized components could render an error frame when default variant is hidden. This PR fixes it.
Testing Details
Types of changes