New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Nextjs] Healthz shows page not found for multisite setup #1443

Merged

ambrauer merged 2 commits into dev from bugfix/581170

Apr 21, 2023

Contributor

illiakovalenko commented Apr 21, 2023 •

edited

Loading

This PR follows the Contribution Guide
Changelog updated

Description / Motivation

When you request the specific route the execution order is:

headers from next.config.js
redirects from next.config.js
middleware
rewrites from next.config.js

because of that it's required to exclude /healthz from middleware execution, otherwise next config rewrite is not executed

Testing Details

Unit Test Added
Manual Test/Other - Scaffoled nextjs, nextjs-styleguide, nextjs-multisite app. Started in connected mode and opened /healthz route. Response is { code: 200, message: "Healthy" }

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

illiakovalenko added 2 commits

April 21, 2023 11:38


          [Nextjs] Healthz shows page not found for multisite setup

8d55c35


          Update CHANGELOG

a8e03ca

ambrauer approved these changes

View reviewed changes

Contributor

ambrauer left a comment

👍

ambrauer merged commit 6213585 into dev

ambrauer deleted the bugfix/581170 branch

April 21, 2023 19:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet