Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Angular] Fix angular app build failure #1448

Merged
merged 2 commits into from
Apr 25, 2023
Merged

[Angular] Fix angular app build failure #1448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
523a639
[angular] fix build errors
art-alexeyenko Apr 24, 2023
253035c
changelog entry
art-alexeyenko Apr 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ Our versioning strategy is as follows:
* `[sitecore-jss-nextjs]` Fix regex for middleware redirects ([#1431](https://github.com/Sitecore/jss/pull/1431))
* `[sitecore-jss-angular]` Fix memory leak in image and link components ([#1435](https://github.com/Sitecore/jss/pull/1435))
* `[templates/nextjs-multisite]` Fix skipped site info fetch ([#1434](https://github.com/Sitecore/jss/pull/1434))
* `[angular]` Fix app build errors. Webpack version is locked at 5.78 due to https://github.com/webpack/webpack/issues/16981 ([#1448](https://github.com/Sitecore/jss/pull/1448))

## 21.1.1

Expand Down
7 changes: 5 additions & 2 deletions packages/create-sitecore-jss/src/templates/angular/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,13 +131,16 @@
},
"//": [
"overrides (for npm) and resolutions (for yarn) used to work around the bug in critters that affect bootstrap: https://github.com/GoogleChromeLabs/critters/issues/103",
"both sections can be removed once critters and css-select versions are updated in build-angular"
"both sections can be removed once critters and css-select versions are updated in build-angular",
"for webpack, we use lower version to fix the angular/webpack bug: https://github.com/webpack/webpack/issues/16981 that prevents project from building",
"remove webpack override when upgrading Angular to next major version"
],
"overrides": {
"@angular-devkit/build-angular": {
"critters": {
"css-select": "4.2.1"
}
},
"webpack": "5.78.0"
}
},
"resolutions": {
Expand Down