[React] Add status message during install #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illiakovalenko
requested changes
Apr 26, 2023
| @@ -78,12 +80,12 @@ const initializeApps = async (noInstall: boolean) => { | |||
| watch = await import(path.resolve('watch.json')); | |||
| const initializers = watch.initializers || []; | |||
| await initRunner(initializers, { ...watch.args, templates: initializers, noInstall }); | |||
| if (watch.args.restoreLockfile) { | |||
There was a problem hiding this comment.
Now seems like I understand why I had an error that I logged in our inbox
On this line you have fs.unlink - so this operation is asynchronous, but it should be synchronous (currently this step can be started, but yarn.lock will not be removed).
fs.unlinkSync can be used. Otherwise for some reasons on some machines it can take more time to remove this file (like it's happened probably on my machine) and result will be unexpected
There was a problem hiding this comment.
Makes sense to me.
|
@sc-addypathania Don't forget to update CHANGELOG |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While scaffolding a react app in monorepo while regenerating the
yarn.lockthe console waits until the dependencies are installed leaving the user confused about the status of the process.Description / Motivation
Testing Details
Types of changes