[nextjs][RAV] Install pre-push-hook to root .git
#1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addy-pathania
force-pushed
the
bug/583940-pre-push-hook
branch
from
6f16f03 to
af21148
Compare
ambrauer
suggested changes
May 9, 2023
packages/create-sitecore-jss/src/templates/angular/scripts/install-pre-push-hook.ts
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/angular/scripts/install-pre-push-hook.ts
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/angular/scripts/install-pre-push-hook.ts
Outdated
Show resolved
Hide resolved
ambrauer
reviewed
May 9, 2023
packages/create-sitecore-jss/src/templates/vue/scripts/install-pre-push-hook.js
Show resolved
Hide resolved
ambrauer
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install the the
prePushHookscript to the root .git folder.Currently the --yes flag defaults prePushHook to true because of which if prePushHook flag is passed explicitly then it is not considered. We want the cli to accept both flags
--yesandprePushHook.This PR follows the Contribution Guide
Changelog updated
Description / Motivation
Testing Details
Types of changes