Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nextjs] Only fetch dictionary data when layout data is present #1608

Merged
merged 2 commits into from
Sep 7, 2023
Merged

[nextjs] Only fetch dictionary data when layout data is present #1608

merged 2 commits into from
Sep 7, 2023

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented Sep 6, 2023 •
edited
Loading

Description / Motivation

Dictionary service can fail and throw a 5xx error when requesting a language on a page with no version in this language. This PR fixes it.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate) - connected, production modes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team September 6, 2023 21:12
@illiakovalenko illiakovalenko merged commit 4b157b2 into dev Sep 7, 2023
@illiakovalenko illiakovalenko deleted the bug/jss-592-500-error-nextjs-dictionary branch September 7, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@art-alexeyenko @illiakovalenko