Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[React][nextjs] Do not apply ErrorBoundaries to empty placeholders #1793

Merged
merged 7 commits into from
May 10, 2024

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented May 9, 2024

Description / Motivation

This PR fixes extra markup being generated for empty placeholders, which broke adding components in Experience Editor.
This also does a couple other things:

  • Add 'empty placeholder' mock data without 'rendering' code blocks. Empty placeholders would not render them.
  • Shorten the code blocks content for empty placeholder data, making it easier to maintain and read
  • make all the 'empty placeholder' unit tests use the 'empty placeholder' mock data

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team May 9, 2024 20:46
Copy link
Contributor

@yavorsk yavorsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@art-alexeyenko art-alexeyenko merged commit e138f58 into dev May 10, 2024
1 check passed
@art-alexeyenko art-alexeyenko deleted the bug/jss-1944-empty-placeholder-boundaries branch May 10, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants