[sitecore-jss-nextjs/react][nextjs/react][v20] Update next to v13, react to 18 #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… hotfix/20.0.0/jss-3453-update-next # Conflicts: # packages/create-sitecore-jss/src/templates/nextjs/package.json
art-alexeyenko
changed the title
… hotfix/20.0.0/jss-3453-update-next # Conflicts: # packages/sitecore-jss-nextjs/package.json # yarn.lock
yavorsk
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
Looks good to me. I could not find anything that is applicable here and missed comparing this to the React 18 and Nextjs13 upgrades done in the main branch. Maybe this should be marked as braking change and upgrade guide added. Some unit tests are failing, otherwise approved.
art-alexeyenko
changed the title
addy-pathania
approved these changes
Jun 28, 2024
art-alexeyenko
changed the title
|
Is this backwards compatible for people/projects who are not yet in a position to run React 18 and Next 13? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
This PR updates nextjs to version 13. In addition to this:
Testing Details
Types of changes